Codex AI review

• Medium packages/aws-durable-execution-sdk-python-otel/src/aws_durable_execution_sdk_python_otel/invocation_plugin.py:419: Non-terminal invocations abandon a recording Workflow span without ending it. Span processors receive on_start but never on_end, potentially leaking processor state on every suspension/retry. Store only a synthetic SpanContext for links, then create and end the real span on terminal completion; add a processor lifecycle test.

• Medium packages/aws-durable-execution-sdk-python-otel/src/aws_durable_execution_sdk_python_otel/invocation_plugin.py:353 and execution_plugin.py:279: Changing the established span name from invocation to Invocation breaks existing dashboards, queries, and the documented telemetry contract. Preserve the lowercase default, or introduce the rename through an explicit compatibility option and update public documentation.

Reviewed commit 5c3adc9dbc33baa54056684bd417571db0023d80. Workflow run

Claude AI review

Summary

This PR adds an execution-scoped Workflow root span to InvocationOtelPlugin (deterministic span ID from the execution ARN, INTERNAL kind, anchored to execution_start_time, exported once on a terminal invocation) and links operation/attempt spans to it while keeping them parented to the invocation span. The core logic is sound: the Workflow span is created as a parentless root in an empty Context(), shares the deterministic execution trace ID via the shared DeterministicIdGenerator, and terminal-status export/status mapping (SUCCEEDED→OK, FAILED→ERROR, non-terminal dropped unended) is correct and mirrors the existing ExecutionOtelPlugin. Per-invocation state (_workflow_span) is properly reset in on_invocation_end to avoid leaks across warm Lambda reuses. Test coverage for the new behavior (terminal/non-terminal export, determinism, root-parenting, invocation-link, configurable name) is thorough.

Findings

1. Undocumented span rename invocation → Invocation — invocation_plugin.py:353 (changed line 334 in diff / new source line) and execution_plugin.py:279. Span names are an observable contract; the PR description only mentions the new Workflow span and does not call out this rename. Downstream X-Ray/OTel queries, dashboards, or span-derived metrics keyed on the literal invocation will silently stop matching. Additionally it leaves stale artifacts:
   • packages/aws-durable-execution-sdk-python-otel/README.md:227 still documents an "invocation" span.
   • Example-package assertions test/plugin/test_otel_plugin.py:75 and test/otel/test_otel_logger_example.py:69 now pass only incidentally by matching the durable.invocation.* attribute keys, not the span name — so they no longer validate the span name.
     Fix: if intentional, update the README and example assertions (assert "Invocation") and document the breaking name change; otherwise revert both call sites to "invocation". (Posted inline.)

Residual test risk

• The two example integration tests (test_otel_plugin.py, test_otel_logger_example.py) are cloud-mode X-Ray tests that were not updated for the rename; they will not catch a span-name regression because their assertions coincidentally match attribute-key substrings. They should be tightened to assert the actual span name.
• No test asserts the Workflow span's trace ID equals the invocation span's trace ID (only span-id determinism and root-parenting are checked), though this is exercised indirectly via parenting/linking.

Reviewed commit 5c3adc9dbc33baa54056684bd417571db0023d80. Workflow run

I think we will be covering the Residual test risk in our conformance testing.